-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --schema-file option to internal drivers #592
Add --schema-file option to internal drivers #592
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I appreciate the refactoring to the driver docs. it really helps make it consistent and easier to update when/if needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, a marathon of small but fantastic updates, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think what is here looks great. I feel like there may still be some work to be done in the driver code.
It looks like get_schema_file
is still called there for the class method schema
and in the function _namelist_schema
. To my knowledge, that function only looks for the uwtools-provided schema file where we might want to instead use the user-provided one, if provided.
@christinaholtNOAA I think the current But |
It just occurred to me: |
I updated this PR to make |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Those changes LGTM. :)
Synopsis
--schema-file
option to all built-in drivers.Type
Impact
Checklist