-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes from integration with SRW's make_orog #603
Fixes from integration with SRW's make_orog #603
Conversation
Co-authored-by: Paul Madden <[email protected]>
…OAA/uwtools into fix_filtered_topo
…fix_filtered_topo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whatever you decide to do w.r.t. the hardcoded orog filename(s) will be fine. On principle, and just repeating what I already argued, I think that values that are not configurable should not appear in configuration, but should be derived from actual configurable values. That might not be practically attainable immediately.
Fix the goof of applying parallel jsonschema to wrong driver.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whew, I think I got through everything - great fixes!
Synopsis
A set of changes to the drivers run as part of SRW's make_orog task.
Also ordered the tests in each of the drivers.
Type
Impact
Checklist