Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement UPP output() method #639

Merged
merged 10 commits into from
Nov 1, 2024

Conversation

maddenp-noaa
Copy link
Contributor

Synopsis

Fixes #627.

Type

  • Documentation
  • Enhancement (adds new functionality)

Impact

  • This is a breaking change (changes existing functionality)

NB control_file is now a required and schema-checked item in the UPP config.

Checklist

  • I have added myself and any co-authors to the PR's Assignees list.
  • I have reviewed the documentation and have made any updates necessitated by this change.

@maddenp-noaa maddenp-noaa self-assigned this Oct 31, 2024
Copy link
Contributor

@christinaholtNOAA christinaholtNOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

Just a few comments below.

src/uwtools/drivers/upp.py Show resolved Hide resolved
src/uwtools/drivers/upp.py Show resolved Hide resolved
src/uwtools/drivers/upp.py Show resolved Hide resolved
Copy link
Contributor

@Byrnetp Byrnetp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maddenp-noaa maddenp-noaa merged commit 916a3fc into ufs-community:main Nov 1, 2024
2 checks passed
@maddenp-noaa maddenp-noaa deleted the gh627-upp-output branch November 1, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Output method for UPP driver
6 participants