Upgrade to Rust v1.72

.pre-commit-config.yaml

@@ -45,7 +45,7 @@ repos:
       - id: codespell
         args: [--ignore-words=.codespellignore]
   - repo: https://github.com/sirosen/check-jsonschema
-    rev: 0.24.1
+    rev: 0.25.0
     hooks:
       - id: check-github-actions
       - id: check-github-workflows

Cargo.toml

@@ -10,6 +10,7 @@ readme = "README.md"
 repository = "https://github.com/uklotzde/djio"
 keywords = ["dj", "controller", "midi", "hid"]
 categories = ["hardware-support"]
+rust-version = "1.72"
 edition = "2021"
 include = ["/src", "/README.md", "/LICENSES"]
 

src/devices/ni_traktor_kontrol_s4mk3/mod.rs

@@ -213,6 +213,7 @@ impl DeviceContext {
         })
     }
 
+    #[allow(clippy::missing_panics_doc)] // Never panics
     pub fn detach(self) -> HidResult<HidDevice> {
         log::info!("Terminating I/O thread");
         self.command_tx

src/midi/midir.rs

@@ -254,6 +254,7 @@ where
     }
 
     #[must_use]
+    #[allow(clippy::missing_panics_doc)] // Never panics
     pub fn detect_dj_controllers(
         &self,
         device_descriptors: &[&MidiDeviceDescriptor],

src/param/atomic.rs

@@ -148,55 +148,79 @@ impl AtomicValue {
         }
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn store_bool(&self, value: bool) {
         debug_assert_eq!(self.value_type(), ValueType::Bool);
         self.as_bool()
             .expect("bool")
             .store(value, ATOMIC_STORE_ORDERING);
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn store_i32(&self, value: i32) {
         debug_assert_eq!(self.value_type(), ValueType::I32);
         self.as_i32()
             .expect("i32")
             .store(value, ATOMIC_STORE_ORDERING);
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn store_u32(&self, value: u32) {
         debug_assert_eq!(self.value_type(), ValueType::U32);
         self.as_u32()
             .expect("u32")
             .store(value, ATOMIC_STORE_ORDERING);
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn store_f32(&self, value: f32) {
         debug_assert_eq!(self.value_type(), ValueType::F32);
         self.as_f32()
             .expect("f32")
             .store(value, ATOMIC_STORE_ORDERING);
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn swap_bool(&self, value: bool) -> bool {
         debug_assert_eq!(self.value_type(), ValueType::Bool);
         self.as_bool()
             .expect("bool")
             .swap(value, ATOMIC_STORE_ORDERING)
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn swap_i32(&self, value: i32) -> i32 {
         debug_assert_eq!(self.value_type(), ValueType::I32);
         self.as_i32()
             .expect("i32")
             .swap(value, ATOMIC_STORE_ORDERING)
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn swap_u32(&self, value: u32) -> u32 {
         debug_assert_eq!(self.value_type(), ValueType::U32);
         self.as_u32()
             .expect("u32")
             .swap(value, ATOMIC_STORE_ORDERING)
     }
 
+    /// # Panics
+    ///
+    /// Panics if the value type does not match.
     pub fn swap_f32(&self, value: f32) -> f32 {
         debug_assert_eq!(self.value_type(), ValueType::F32);
         self.as_f32()