Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate filters and series in Streamlit UI for post-processing #278

Merged
merged 7 commits into from
Mar 8, 2024

Conversation

pineapple-cat
Copy link
Collaborator

@pineapple-cat pineapple-cat commented Mar 4, 2024

Addresses #269.

  • Filter/series addition.
  • Filter/series removal.
  • Redundant column type removal.

Bonus:

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.

Verified

This commit was signed with the committer’s verified signature.
…pe removal.
@pineapple-cat pineapple-cat requested a review from ilectra March 4, 2024 19:22
@pineapple-cat pineapple-cat linked an issue Mar 4, 2024 that may be closed by this pull request
1 task
@ilectra
Copy link
Collaborator

ilectra commented Mar 5, 2024

Looks pretty good! Just a couple of comments:

  • Can the df not be written out into the console every time the plot is updated? If it's too hard to do this, don't worry about it.
  • The update_ui function is getting a bit big. See if you can modularise it a bit/move bits of it into separate functions, and add some comments in the code of what each section does.

Sorry, something went wrong.

@pineapple-cat pineapple-cat merged commit 10c6773 into main Mar 8, 2024
4 checks passed
@pineapple-cat pineapple-cat deleted the post-processing_ui-filters branch March 8, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants