Create resource group to apply memory setting for Isambard Instinct #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaanolgu
reviewed
Mar 13, 2024
Co-authored-by: kaanolgu <[email protected]>
giordano
commented
Mar 13, 2024
|
The reason why we haven't dealt with the memory as a proper resource so far is because it's complicated: it's a mixture of application-specific (memory requirements can vary a lot) and system-specific (I think for some schedulers it's the memory per CPU, in others it's the total memory), so it's really hard to come up with reasonable default values which work well in all situations. |
|
@kaanolgu is it good to go now? |
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kaanolgu can you please check this works for you? If I remember correctly, we need to define the
extra_resourceso that it's applied in the configuration, but in this case we don't need (yet?) to define any custom variable, so I think an empty dictionary should work?