Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosma8 Update Configurations and Spack Environments #311

Merged
merged 25 commits into from
May 23, 2024

Conversation

gokmenkilic
Copy link
Collaborator

@gokmenkilic gokmenkilic commented Apr 22, 2024

This PR address the enhancements in issue #230.

Please see below about the changes.

I have tested some of benchmarks on Cosma8 and updated following references values:



  • grid
  • swift
  • sombrero

Spack:


Updated some of external packages and added new compilers.

@giordano giordano force-pushed the gk/cosma-spack-env branch from 44fb990 to 47f5b14 Compare April 25, 2024 15:51
@giordano giordano force-pushed the gk/cosma-spack-env branch 3 times, most recently from 8577a2d to 66d3bac Compare April 25, 2024 15:57
@giordano giordano force-pushed the gk/cosma-spack-env branch from 66d3bac to 4e309c1 Compare April 25, 2024 16:05
benchmarks/reframe_config.py Outdated Show resolved Hide resolved
docs/systems.md Show resolved Hide resolved
@tkoskela
Copy link
Member

tkoskela commented May 2, 2024

Hi Gokmen, are you still working on this or is it ready for review?

@gokmenkilic
Copy link
Collaborator Author

gokmenkilic commented May 2, 2024

Hi Gokmen, are you still working on this or is it ready for review?

Hi Tuomas,

It is now ready for review.

@gokmenkilic gokmenkilic marked this pull request as ready for review May 16, 2024 11:14
Copy link
Member

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Gokmen, thanks for adding this. The changes to the spack environment look fine. I've left a few comments on the other changes.

.github/workflows/docs.yml Outdated Show resolved Hide resolved
benchmarks/reframe_config.py Outdated Show resolved Hide resolved
benchmarks/spack/cosma8/compute-node/spack.yaml Outdated Show resolved Hide resolved
gokmenkilic and others added 2 commits May 21, 2024 17:42
already added node id

Co-authored-by: Tuomas Koskela <[email protected]>
@gokmenkilic
Copy link
Collaborator Author

Hi Gokmen, thanks for adding this. The changes to the spack environment look fine. I've left a few comments on the other changes.

Hi Thomas,

Thank you for reviewing and I made the changes.

Copy link
Member

@tkoskela tkoskela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@tkoskela tkoskela merged commit 5db9612 into ukri-excalibur:main May 23, 2024
5 checks passed
@gokmenkilic gokmenkilic deleted the gk/cosma-spack-env branch June 7, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants