-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cosma8 Update Configurations and Spack Environments #311
Cosma8 Update Configurations and Spack Environments #311
Conversation
… into gk/cosma-spack-env
… into gk/cosma-spack-env
44fb990
to
47f5b14
Compare
8577a2d
to
66d3bac
Compare
66d3bac
to
4e309c1
Compare
Hi Gokmen, are you still working on this or is it ready for review? |
Hi Tuomas, It is now ready for review. |
Co-authored-by: Tuomas Koskela <[email protected]>
Co-authored-by: Mosè Giordano <[email protected]>
… into gk/cosma-spack-env
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Gokmen, thanks for adding this. The changes to the spack environment look fine. I've left a few comments on the other changes.
already added node id Co-authored-by: Tuomas Koskela <[email protected]>
Hi Thomas, Thank you for reviewing and I made the changes. |
Co-authored-by: Tuomas Koskela <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now!
This PR address the enhancements in issue #230.
Please see below about the changes.
I have tested some of benchmarks on Cosma8 and updated following references values:
Spack:
Updated some of external packages and added new compilers.