--digits added, --specials no longer includes digits #88
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes implemented the following things to partially address issue #57
SPECIAL_CHARS
and therefore the--specials NUM
output--digits NUM
option that inserts characters from the newDIGIT_CHARS
variableIt does not update the README.rst, to reflect these changes as I think that gets rendered somehow? I note that the developer documentation seems to be out of date as I had to jump through a couple hoops to get the tests enabled.
I had another idea that I might implement: modify the
--delimiter
option so that if it gets multiple chars, it selects one at random from the list. I.e.diceware --delimiter '1-#' -n 4
currently could outputCorrect1-#Horse1-#Battery1-#Staple
but with that implemented, it would output:Correct-Horse1Battery#Staple