Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--digits added, --specials no longer includes digits #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

alanhoyle
Copy link
Contributor

The changes implemented the following things to partially address issue #57

  1. removes digit characters from SPECIAL_CHARS and therefore the --specials NUM output
  2. adds a new --digits NUM option that inserts characters from the new DIGIT_CHARS variable
  3. adds tests to confirm that both of these work.

It does not update the README.rst, to reflect these changes as I think that gets rendered somehow? I note that the developer documentation seems to be out of date as I had to jump through a couple hoops to get the tests enabled.

I had another idea that I might implement: modify the --delimiter option so that if it gets multiple chars, it selects one at random from the list. I.e. diceware --delimiter '1-#' -n 4 currently could output Correct1-#Horse1-#Battery1-#Staple but with that implemented, it would output: Correct-Horse1Battery#Staple

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant