Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome 131 #341

Merged
merged 4 commits into from
Dec 6, 2024
Merged

Chrome 131 #341

merged 4 commits into from
Dec 6, 2024

Conversation

blakebyrnes
Copy link
Contributor

@blakebyrnes blakebyrnes commented Dec 6, 2024

Summary by CodeRabbit

Release Notes

  • New Features

    • Enhanced screenshot functionality with flexible options for image format and quality.
    • Improved browser stack and headless indicator management in the polyfill process.
  • Bug Fixes

    • Refined cookie management to ensure compliance with SameSite policies and user interactions.
  • Chores

    • Updated dependencies, including major version upgrades for tough-cookie and @ulixee/chrome.
  • Documentation

    • Adjusted test cases to reflect changes in operating system name handling, improving clarity in user agent options.

@blakebyrnes blakebyrnes merged commit 3160f05 into main Dec 6, 2024
23 of 27 checks passed
Copy link

coderabbitai bot commented Dec 6, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request includes updates across various files, primarily enhancing the handling of operating system names and browser compatibility. Key changes involve expanding the Node.js test matrix, updating browser versions, and introducing new properties in JSON configurations. Additionally, several classes and methods have been refined for better type safety and clarity, particularly in relation to the operatingSystemCleanName. The modifications also encompass dependency updates and adjustments to test cases to reflect these changes.

Changes

File Change Summary
.github/workflows/lint-and-test.yml Updated Node.js versions to include 22, modified browser version for node-version: 20.x, added new entry for chrome-120-0.
agent/main/lib/Page.ts Added import for IFrame, updated screenshot method to accept options with validation for jpegQuality.
agent/main/package.json Updated @ulixee/chrome to version 131-0 and tough-cookie to version 5.0.0.
browser-emulator-builder/lib/json-creators/DomPolyfill.ts Modified filterNotSupportedByPolyfillPlugin to exclude window.navigator.languages and window.navigator.language.
browser-emulator-builder/scripts/generateEmulatorData.ts Added conditional check for BROWSER_ID in browser ID filtering, adjusted console log indentation.
browser-profiler/dom-bridger/index.ts Loaded browserstack-indicators.json, updated filtering logic for polyfills.
browser-profiler/dom-bridger/lib/extractors/BrowserstackIndicatorExtractor.ts Updated definitePatterns, extraAddPatterns, and extraChangePatterns to enhance pattern recognition.
browser-profiler/dom-bridger/lib/extractors/HeadlessIndicatorExtractor.ts Reduced definitePatterns to one entry for simplification.
browser-profiler/dom-bridger/lib/extractors/InstanceChangeExtractor.ts Added and removed various properties in extraChangePatterns for instance tracking.
core/lib/Session.ts Reformatted constructor parameters for readability, renamed operatingSystemName to operatingSystemCleanName.
double-agent/config/data/path-patterns/browserstack-indicators.json Modified entries for tracking browser capabilities.
double-agent/config/data/path-patterns/headless-indicators.json Cleared removed entries and simplified structure.
double-agent/config/data/path-patterns/instance-variations.json Updated numerous properties related to performance and navigator attributes.
plugins/default-browser-emulator/lib/BrowserData.ts Updated destructuring for userAgentOption to use operatingSystemCleanName.
plugins/default-browser-emulator/lib/UserAgentOptions.ts Updated methods to utilize operatingSystemCleanName for consistency.
plugins/default-browser-emulator/lib/helpers/configureSessionTcp.ts Changed destructuring to use operatingSystemCleanName.
plugins/default-browser-emulator/lib/plugins/FirstPartyCookiesPlugin.ts Removed type assertions for improved type safety in cookie handling methods.
plugins/default-browser-emulator/package.json Updated tough-cookie version and removed @types/tough-cookie.
plugins/default-browser-emulator/test/selectUserAgentOptions.test.ts Updated assertions to check operatingSystemCleanName.
plugins/default-browser-emulator/test/userAgentStrings.test.ts Renamed test case and updated assertions for operatingSystemCleanName.
specification/plugin/IUserAgentOption.ts Renamed operatingSystemName to operatingSystemCleanName.

Poem

🐰 In the meadow where code does play,
A rabbit hops with joy today.
With cleaner names and versions anew,
Our browser's ready, fast, and true!
So let us cheer, with a joyful thump,
For every change, we’ll gladly jump! 🥕


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 831927c and b14bf27.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (21)
  • .github/workflows/lint-and-test.yml (1 hunks)
  • agent/main/lib/Page.ts (0 hunks)
  • agent/main/package.json (1 hunks)
  • browser-emulator-builder/lib/json-creators/DomPolyfill.ts (1 hunks)
  • browser-emulator-builder/scripts/generateEmulatorData.ts (2 hunks)
  • browser-profiler/dom-bridger/index.ts (5 hunks)
  • browser-profiler/dom-bridger/lib/extractors/BrowserstackIndicatorExtractor.ts (1 hunks)
  • browser-profiler/dom-bridger/lib/extractors/HeadlessIndicatorExtractor.ts (1 hunks)
  • browser-profiler/dom-bridger/lib/extractors/InstanceChangeExtractor.ts (1 hunks)
  • core/lib/Session.ts (2 hunks)
  • double-agent/config/data/path-patterns/browserstack-indicators.json (1 hunks)
  • double-agent/config/data/path-patterns/headless-indicators.json (1 hunks)
  • double-agent/config/data/path-patterns/instance-variations.json (1 hunks)
  • plugins/default-browser-emulator/lib/BrowserData.ts (1 hunks)
  • plugins/default-browser-emulator/lib/UserAgentOptions.ts (7 hunks)
  • plugins/default-browser-emulator/lib/helpers/configureSessionTcp.ts (1 hunks)
  • plugins/default-browser-emulator/lib/plugins/FirstPartyCookiesPlugin.ts (3 hunks)
  • plugins/default-browser-emulator/package.json (1 hunks)
  • plugins/default-browser-emulator/test/selectUserAgentOptions.test.ts (1 hunks)
  • plugins/default-browser-emulator/test/userAgentStrings.test.ts (2 hunks)
  • specification/plugin/IUserAgentOption.ts (1 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@blakebyrnes blakebyrnes deleted the chrome-131 branch December 6, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant