NOISSUE - Add Service Layer Tracing #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rodneyosodo <[email protected]>
rodneyosodo
force-pushed
the
NOISSUE-servicelayertracing
branch
from
c6f6912
to
fb596ab
Compare
rodneyosodo
changed the title
rodneyosodo
changed the title
Signed-off-by: rodneyosodo <[email protected]>
agent/tracing/tracing.go
Outdated
| } | ||
|
|
||
| func (tm *tracingMiddleware) Run(ctx context.Context, cmp agent.Computation) (string, error) { | ||
| ctx, span := tm.tracer.Start(context.Background(), "run", trace.WithAttributes( |
There was a problem hiding this comment.
Can you explain me briefly why we're using here context.Background() instead of ctx passed as an argument. I don't say we should, but I'm not sure.
There was a problem hiding this comment.
This was an over sight.
Signed-off-by: rodneyosodo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.