Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NOISSUE - Update Protocol Buffer workflow #30

Merged
merged 1 commit into from
Jul 26, 2023
Merged

NOISSUE - Update Protocol Buffer workflow #30

merged 1 commit into from
Jul 26, 2023

Conversation

rodneyosodo
Copy link
Contributor

  • move agent.proto to agent service
  • produce updated artifacts from make protoc
  • Add CI to check if generated code is up to date

@rodneyosodo
Update ProtoC workflow
d2fff75 
Signed-off-by: rodneyosodo <[email protected]>
drasko
drasko approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@drasko drasko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

agent/api/grpc/client.go
const (
svcName = "agent_proto.AgentService"
)
const svcName = "agent.agent.AgentService"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the problem that we put agent pkg inside the agent repo, and we probably had to do this because of CLI.

I will approve now, but in the future, I would suggest that we take CLI out in a separate repo, or that we move everything to a monorepo in the future (once we open-source the Cocos) - like we did for Mainflux.

darkodraskovic
darkodraskovic approved these changes Jul 26, 2023
View reviewed changes
Copy link
Collaborator

@darkodraskovic darkodraskovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkodraskovic darkodraskovic merged commit 972e153 into main Jul 26, 2023
2 checks passed
@darkodraskovic darkodraskovic deleted the NOISSUE-cleanup branch July 26, 2023 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drasko drasko drasko approved these changes

@darkodraskovic darkodraskovic darkodraskovic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rodneyosodo @drasko @darkodraskovic