-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added deliveries workspace view to the webhook details workspace #18175
Added deliveries workspace view to the webhook details workspace #18175
Conversation
Hi Andy, First of all, everything worked as expected in this PR. As you have already noticed, I have added a couple of updates to the PR. This was the perfect opportunity to get this feature aligned with some of the rest of the UI/code base. I have fixed a couple of smaller hiccups in your additions:
Here are the extra changes I made:
Everything should work the exact same as you left it. Can I get you to do a sanity check of the feature? A couple of screenshots |
Thanks Mads, great work. As I said... hopefully there was something you could work from where I left it! I'll check it out locally as you say. Just quickly though:
I also had this in an earlier version... but then I thought, the URL could change. I.e. you can create a webhook, start using it, and then change the URL to a different one. So that's why in the end I had it in the column list. Maybe it's not that likely, but seems like it has been anticipated in that the URL is stored for every delivery record in the |
Otherwise all working as expected for me. @Zeegaan - please could you have a quick look over the back-end aspects of this PR? And maybe you have a view on my comment above from when you were designing the data model for this. Thanks. |
@AndyButland Ah, it's a good point. If that is the case then I think it is even more important we get a name as part of the Webhook model at some point. |
@AndyButland Looks good to me. I think ultimately we could have a Nullable name, and then default back to the URL, if you don't want to give it a friendly name 👍 |
@AndyButland Url is back for deliveries again 👍 Let me know what will happen with the friendly name. It would be awesome to add in the near future 😃 Feel free to merge when happy. |
Prerequisites
Resolves: #17754
Description
This PR adds an additional workspace view to the webhook details workspace, showing the deliveries for that webhook.
I've amended this slightly from 13 as it seemed to make more sense to show deliveries for each webhook as a separate paged list, rather than one long list for all of them.
To Test: