Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't filter on published state for media descendent queries #18214

Open
wants to merge 1 commit into
base: v15/dev
Choose a base branch
from

Conversation

AndyButland
Copy link
Contributor

Prerequisites

  • I have added steps to test this contribution in the description below

Fixes: #18211

Description

This PR should resolve the reported issue. On stepping through I could see we were filtering on published state, without first checking we are looking at an entity that can be published. So for documents it worked, but not for media.

To Test:

  • See the code sample in the reported issue.
  • Previously this would return just the root nodes, but with this update you should get all media.
  • A similar query for content should continue to omit unpublished items.

@AndyButland
Copy link
Contributor Author

Best to hold on this one @nikolajlauridsen actually... @kjac is going to do some rework on this area, so it makes sense that he considered this as part of that effort.

@nikolajlauridsen nikolajlauridsen removed their assignment Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants