Skip to content

Commit

Permalink
Remove bucket assumption(s) and formats encoded in the htsget url(s).…
Browse files Browse the repository at this point in the history
… Use readable names for methods instead of just m.
  • Loading branch information
brainstorm committed Jan 20, 2025
1 parent 240da06 commit 456ed05
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions ga4gh/htsget/compliance/config/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,8 @@

# URL TEMPLATES
BASE_URL = "{base_url}"
DEFAULT_READS_URLPATH = "/reads/htsgetlambdastack-bucket83908e77-0bbbuwy4lrax/bam"
DEFAULT_VARIANTS_URLPATH = "/variants/htsgetlambdastack-bucket83908e77-0bbbuwy4lrax/vcf"
DEFAULT_READS_URLPATH = "/reads/"
DEFAULT_VARIANTS_URLPATH = "/variants/"
ID_URLPATH = "/{obj_id}"

# OBJECT IDs FOR TEST CASES
Expand Down
4 changes: 2 additions & 2 deletions ga4gh/htsget/compliance/config/test_case_property_matrix.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import os
from ga4gh.htsget.compliance.config import constants as c
from ga4gh.htsget.compliance.config import methods as m
from ga4gh.htsget.compliance.config import methods

def construct_reads_test_cases_matrix():

Expand Down Expand Up @@ -57,7 +57,7 @@ def construct_name(reads_id, reads_format, reads_reference):
"name": construct_name(
reads_id, reads_format, ''#, reads_reference
),
"url_function": m.FORMAT_READS_URL,
"url_function": methods.FORMAT_READS_URL,
"url_params": params,
"obj_id": reads_id,
"expected_response_status": c.STATUS_OK,
Expand Down

0 comments on commit 456ed05

Please sign in to comment.