Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support vue tech stack #1922
feat: support vue tech stack #1922
Changes from 9 commits
6d63caa
34698d8
2ba1b73
7c2660b
6ae0f0c
2776eee
15f3093
1f62fe9
5b362cb
9c8fb92
f32692b
6f39fa1
ac81c9d
92b1f64
0019aad
8008c6c
48c7c3d
965303d
c70cf88
9a1732d
4f4d6fd
4f917e9
79455c7
db314ff
90efd70
7292825
1e6c37d
369da5f
1cf5168
acd379c
e619561
68df182
034da65
75a3d3b
995322f
6682bf1
b9402bb
ad559ce
bc87ccc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的思路是否可以改成在 techStack 上新增
getEntryScriptCode
方法,该方法是可选的,Vue 技术栈会提取.vue
中的 script 并返回,rehypeDemo 再将内容作为entryPointCode
传给parseBlockAsset
解析器好处是不新增配置项,复杂度都集中在 techStack 内部
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
已经在本地实现了,但是具体的传递模式还是得再讨论讨论
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个不建议通过插件配置来增加导入,可以引导用户使用 global.ts: https://d.umijs.org/guide/project-structure#%E5%85%A8%E5%B1%80%E8%84%9A%E6%9C%AC
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
使用global.ts不一定可行,主要是因为这个是注入到demo当中的,不是应用当中的