Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overrides :root pseudo class #12092

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Jan 24, 2024

fix #12089

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 5:05am

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b31564) 28.76% compared to head (3e74642) 28.76%.
Report is 1 commits behind head on master.

Files Patch % Lines
...ges/preset-umi/src/features/overrides/transform.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12092   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files         489      489           
  Lines       14968    14970    +2     
  Branches     3560     3561    +1     
=======================================
+ Hits         4305     4306    +1     
- Misses       9897     9898    +1     
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crazyair
Copy link

不是开发者吗,开分支还要用 fork 的仓库开?https://github.com/MoeYc/umi/tree/fix/overrides-root

@fz6m
Copy link
Contributor Author

fz6m commented Jan 25, 2024

在本仓库提交代码会有几十个 github actions 运行,如果下次我继续提交上次的 CI 就会被取消,然后我会收到几十封 CI 被取消的邮件,每次 git push 都收到几十封邮件干扰是很大的,所以无论什么 PR 我都会在 fork 的项目提交。

@fz6m fz6m merged commit af15365 into umijs:master Jan 25, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] :root 设置 var 在生产环境失效
2 participants