Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable tsx node warning #12093

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Conversation

fz6m
Copy link
Contributor

@fz6m fz6m commented Jan 24, 2024

  1. 固定 tsx3.12.2 ,因为 3.14.0 没法在 node v18.19.0 以上运行,我们也没法升级更高的版本,因为再升级就没法兼容 node 14 了。

  2. 禁掉 tsx 的 node warning ,对于一个小脚本来说,禁掉 node warning 无关紧要。

如果用户有条件的话,应该是自己安装最新的 tsx 来运行脚本,或者 umi run 应该是一个按需安装 tsx 的设计(根据 node 版本不同安装不同版本的 tsx )。

更多上下文信息:#11981

cc @stormslowly

Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Jan 24, 2024 5:28am

Copy link

codecov bot commented Jan 24, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (8b31564) 28.76% compared to head (66b1ae7) 28.76%.
Report is 1 commits behind head on master.

Files Patch % Lines
packages/plugin-run/src/index.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12093   +/-   ##
=======================================
  Coverage   28.76%   28.76%           
=======================================
  Files         489      489           
  Lines       14968    14968           
  Branches     3560     3560           
=======================================
  Hits         4305     4305           
  Misses       9897     9897           
  Partials      766      766           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sorrycc sorrycc merged commit 98ee5b1 into umijs:master Feb 22, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants