chore: tmp solution for runtime server loader path #12243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WalkthroughThe update in Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
|
Size Change: +124 B (0%) Total Size: 9.9 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12243 +/- ##
==========================================
- Coverage 28.41% 28.41% -0.01%
==========================================
Files 492 492
Lines 15166 15167 +1
Branches 3626 3627 +1
==========================================
Hits 4310 4310
- Misses 10084 10085 +1
Partials 772 772 ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/renderer-react/src/dataFetcher.ts (1 hunks)
Additional comments (2)
packages/renderer-react/src/dataFetcher.ts (2)
- 15-18: The temporary solution for customizing the server loader request path uses a global variable
serverLoaderPathor falls back tobasename. While this approach addresses the immediate need, consider the following:
- Security/PII Leakage: Ensure that the use of
window.location.hrefin constructing the query does not inadvertently expose sensitive information.- Maintainability: The FIXME comment is helpful, but it would be beneficial to track this workaround with a more formal tracking system (e.g., issue tracker) to ensure it's addressed in future refactoring efforts.
- Performance: Verify that this dynamic URL construction does not introduce significant performance overhead, especially in high-traffic scenarios.
Would you like assistance in creating a tracking issue for this FIXME?
- 12-21: > 📝 NOTE
This review was outside the diff hunks, and no overlapping diff hunk was found. Original lines [22-24]
The
withEndSlashutility function correctly ensures that a given string ends with a slash. This is a simple yet effective way to handle URL path construction.
Comment on lines
15
to
18
| // FIXME: 先临时解自定义 serverLoader 请求路径的问题，后续改造 serverLoader 时再提取成类似 runtimeServerLoader 的配置项 | ||
| const url = `${withEndSlash( | ||
| (window as any).serverLoaderPath || basename, | ||
| )}__serverLoader?${query}`; |
There was a problem hiding this comment.
Consider using a more robust method for URL construction to avoid potential issues with path concatenation. For example, using the URL or URLSearchParams API can provide a safer and more predictable way to construct URLs, especially when dealing with query parameters and base paths.
- const url = `${withEndSlash((window as any).serverLoaderPath || basename,)}__serverLoader?${query}`;
+ const serverLoaderBasePath = (window as any).serverLoaderPath || basename;
+ const serverLoaderURL = new URL(`__serverLoader?${query}`, withEndSlash(serverLoaderBasePath));
+ const url = serverLoaderURL.toString();Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| // FIXME: 先临时解自定义 serverLoader 请求路径的问题，后续改造 serverLoader 时再提取成类似 runtimeServerLoader 的配置项 | |
| const url = `${withEndSlash( | |
| (window as any).serverLoaderPath || basename, | |
| )}__serverLoader?${query}`; | |
| // FIXME: 先临时解自定义 serverLoader 请求路径的问题，后续改造 serverLoader 时再提取成类似 runtimeServerLoader 的配置项 | |
| const serverLoaderBasePath = (window as any).serverLoaderPath || basename; | |
| const serverLoaderURL = new URL(`__serverLoader?${query}`, withEndSlash(serverLoaderBasePath)); | |
| const url = serverLoaderURL.toString(); |
sorrycc
approved these changes
Mar 28, 2024
There was a problem hiding this comment.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- packages/renderer-react/src/dataFetcher.ts (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- packages/renderer-react/src/dataFetcher.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
临时方案解运行时自定义 serverLoader 请求路径的需求，不进 Changelog
最终解会在后续改造 serverLoader 时做，提供类似
ssr.runtimeServerLoader的配置项Summary by CodeRabbit