Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wind convention parameters #79

Merged
merged 11 commits into from
Sep 23, 2024
Merged

wind convention parameters #79

merged 11 commits into from
Sep 23, 2024

Conversation

vincelhx
Copy link
Collaborator

oceano / meteo wind

@vincelhx vincelhx marked this pull request as draft September 17, 2024 11:25
@Skealz
Copy link
Collaborator

Skealz commented Sep 17, 2024

Maybe, in the config, wind_dir_convention or dir_convention are more explicit ?

@vincelhx
Copy link
Collaborator Author

I took advantage of this PR to change a bit the call of preprocess

@vincelhx
Copy link
Collaborator Author

I added a function to check that incidence range is included in LUT incidence range ;
in order to prevent user ; if not included, inversion will use wrong inversion angle and so provide wrong wind values

@vincelhx
Copy link
Collaborator Author

i also renamed model_vv => model_co et model_vh => model_cross

@Skealz Skealz marked this pull request as ready for review September 23, 2024 14:27
@Skealz Skealz merged commit 8b67c0b into umr-lops:main Sep 23, 2024
1 check passed
@agrouaze agrouaze linked an issue Sep 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RCM output file nomenclature and attributes : add acquisition mode
2 participants