-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance accessibility a11y #63
Open
Muhnad
wants to merge
5
commits into
una:gh-pages
Choose a base branch
from
Muhnad:gh-pages
base: gh-pages
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
<form> | ||
<input type="color" aria-label="Select a color" /> | ||
<button type="submit">Submit</button> | ||
</form> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,19 @@ | ||
<div class="togglebox"> | ||
<input id="toggle1" type="radio" name="toggle" /> | ||
<label for="toggle1">Label 1</label> | ||
<div class="togglebox" role="tablist"> | ||
<input id="toggle1" type="radio" name="toggle" aria-hidden="true" /> | ||
<label for="toggle1" role="tab" tabindex="0" aria-describedby="content-area1">Label 1</label> | ||
<section id="content1"> | ||
<p>Content for the first accordion</p> | ||
<p id="content-area1">Content for the first accordion</p> | ||
</section> | ||
|
||
<input id="toggle2" type="radio" name="toggle" /> | ||
<label for="toggle2">Label 2</label> | ||
<input id="toggle2" type="radio" name="toggle" aria-hidden="true" /> | ||
<label for="toggle2" role="tab" tabindex="0" aria-describedby="content-area2">Label 2</label> | ||
<section id="content2"> | ||
<p>Content for the second accordion</p> | ||
<p id="content-area2">Content for the second accordion</p> | ||
</section> | ||
|
||
<input id="toggle3" type="radio" name="toggle" /> | ||
<label for="toggle3">Label 3</label> | ||
<input id="toggle3" type="radio" name="toggle" aria-hidden="true" /> | ||
<label for="toggle3" role="tab" tabindex="0" aria-describedby="content-area3">Label 3</label> | ||
<section id="content3"> | ||
<p>Content for the third accordion</p> | ||
<p id="content-area3">Content for the third accordion</p> | ||
</section> | ||
</div> | ||
</div> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,9 @@ | ||
<!-- thumbnail image wrapped in a link --> | ||
<a href="#img1"> | ||
<img src="img.jpg" class="thumbnail"> | ||
<img src="img.jpg" class="thumbnail" alt="image description"> | ||
</a> | ||
|
||
<!-- lightbox container hidden with CSS --> | ||
<a href="#" class="lightbox" id="img1"> | ||
<img src="img.jpg"> | ||
</a> | ||
<img src="img.jpg" alt="image description"> | ||
</a> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,25 @@ | ||
<div class="tabs"> | ||
<div class="tab"> | ||
<div class="tabs" role="tablist"> | ||
<div class="tab" role="tab"> | ||
<input type="radio" name="tabgroup" id="tab-1" checked> | ||
<label for="tab-1">Label One</label> | ||
<label for="tab-1" tabindex="0" aria-describedby="content-area1">Label One</label> | ||
<div class="content"> | ||
<p>Tab One Content</p> | ||
<p id="content-area1">Tab One Content</p> | ||
</div> | ||
</div> | ||
|
||
<div class="tab"> | ||
<div class="tab" role="tab"> | ||
<input type="radio" name="tabgroup" id="tab-2"> | ||
<label for="tab-2">Label Two</label> | ||
<label for="tab-2" tabindex="0" aria-describedby="content-area2">Label Two</label> | ||
<div class="content"> | ||
<p>Tab Two Content</p> | ||
<p id="content-area2">Tab Two Content</p> | ||
</div> | ||
</div> | ||
|
||
<div class="tab"> | ||
<div class="tab" role="tab"> | ||
<input type="radio" name="tabgroup" id="tab-3"> | ||
<label for="tab-3">Label Three</label> | ||
<label for="tab-3" tabindex="0" aria-describedby="content-area3">Label Three</label> | ||
<div class="content"> | ||
<p>Tab Three Content</p> | ||
<p id="content-area3">Tab Three Content</p> | ||
</div> | ||
</div> | ||
</div> | ||
</div> |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this locally and it doesn't seem to make the toggle keyboard accessible still :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it on NVDA & Chromevox and it's work correctly with a keyboard if you used tab and up,down arrow will hear and see the content.