Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update contents of test credential #194

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

ashleythedeveloper
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • πŸ• Feature
  • πŸ› Bug Fix
  • πŸ“ Documentation Update
  • 🎨 Style
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ”₯ Performance Improvements
  • βœ… Test
  • πŸ€– Build
  • πŸ” CI
  • πŸ“¦ Chore (Release)
  • ⏩ Revert

Description

This PR fixes the invalid downloadable test credential by replacing it with a new DPP with an updated JWT header conforming with the JOSE spec.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

Download and test the old test credential
Screenshot 2025-01-10 at 12 09 40β€―pm

Download and test the new test credential
Screenshot 2025-01-10 at 10 03 20β€―am

Added tests?

  • πŸ‘ yes
  • πŸ™… no, because they aren't needed
  • πŸ™‹ no, because I need help

Added to documentation?

  • πŸ“– Mock App docs site
  • πŸ“œ README.md
  • πŸ“• storybook
  • πŸ™… no documentation needed

[optional] Are there any post-deployment tasks we need to perform?

Copy link

Code Coverage Report

Lines Statements Branches Functions
Coverage: 82%
81.07% (3307/4079) 65.18% (717/1100) 72.06% (374/519)
Title Lines Statements Branches Functions
All packages Coverage: 82%
81.07% (3307/4079) 65.18% (717/1100) 72.06% (374/519)
Components Coverage: 84%
84.03% (516/614) 69.36% (120/173) 77.23% (95/123)
Mock app Coverage: 71%
71.89% (371/516) 53.23% (74/139) 68.14% (77/113)
Services Coverage: 81%
79.08% (1025/1296) 64.15% (247/385) 76.08% (105/138)
UNTP test suite Coverage: 85%
85.74% (1083/1263) 81.03% (141/174) 67.21% (41/61)
VC test suite Coverage: 100%
100% (20/20) 100% (2/2) 100% (4/4)
UNTP Playground Coverage: 83%
80.44% (325/404) 58.95% (135/229) 66.66% (56/84)

@ashleythedeveloper ashleythedeveloper merged commit 43d83ec into next Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants