Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: check validation rules for added values #13

Closed
wants to merge 1 commit into from

Conversation

kshychko
Copy link
Contributor

@kshychko kshychko commented Feb 9, 2024

Code List

  • Recommendation No. 24 Trade and Transport Status Codes
  • Recommendation No. 28 Codes for Types of Means of Transport

Maintenance Request issue

Ref #{issue_number}

Mentions:

@uncefact/vocab-codes-maintainers

Copy link

github-actions bot commented Feb 9, 2024

A new code list value was added, but CI was not set to +:

{"CI":"","Code":"380","Name":"New Code #380","Description":"New code #380 description."}
{"CI":"*","Code":"381","Name":"New Code #381","Description":"New code #381 description."}

This was referenced Feb 9, 2024
Copy link
Contributor Author

@kshychko kshychko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change CI for new records to + according to the suggested changes

@@ -344,3 +344,5 @@ CI,Code,Name,Description
,377,"Equipment, not released by equipment operator",The equipment has not been released by the equipment operator.
+,378,Delivery Order Issued,Delivery Order for the goods/consignment/equipment/means has been issued.
+,379,Cleared for container release,The procedures of containers’ release from container yard have been cleared by all authorities and private sectors.
,380,New Code #380,New code #380 description.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
,380,New Code #380,New code #380 description.
+,380,New Code #380,New code #380 description.

@@ -344,3 +344,5 @@ CI,Code,Name,Description
,377,"Equipment, not released by equipment operator",The equipment has not been released by the equipment operator.
+,378,Delivery Order Issued,Delivery Order for the goods/consignment/equipment/means has been issued.
+,379,Cleared for container release,The procedures of containers’ release from container yard have been cleared by all authorities and private sectors.
,380,New Code #380,New code #380 description.
*,381,New Code #381,New code #381 description.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
*,381,New Code #381,New code #381 description.
+,381,New Code #381,New code #381 description.

@kshychko kshychko requested a review from a team February 9, 2024 11:26
@kshychko kshychko closed this Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant