Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

chore: Update TestSuiteRun, TestSuiteRunSummary, Note, and associated redux files to TypeScript with useSelector/useDispatch hooks #357

Closed

Conversation

hwinsby
Copy link
Contributor

@hwinsby hwinsby commented Jan 3, 2024

Description:

TestSuiteRun and TestSuiteRunSummary component files:

  • Converted to TypeScript
  • Replaced connect from react-redux with hooks useSelector and useDispatch

Redux files associated with TestSuiteRun.tsx and TestSuiteRunSummary.tsx converted to TypeScript:

  • Action files: errorNotificationActions, keystoreActions, testRunActions, testSuiteRunActions
  • Reducer files: keystoreReducer & testSuiteRunReducer
  • Selector files (created): keystore & testSuiteRun

Note.tsx component file:

  • Replaced connect from react-redux with hooks useSelector and useDispatch

No functional changes were made, only refactors. Screenshots below demonstrate no visual changes before vs. after.

Before:
before

After:
after

Does this PR introduce a breaking change?

  • Yes
  • No

Does this PR fix an open issue?

  • Yes
  • No

@hwinsby hwinsby changed the title Hiw tsify components chore: Update TestSuiteRun, TestSuiteRunSummary, Note, and associated redux files to TypeScript with useSelector/useDispatch hooks Jan 3, 2024
@bucko13
Copy link
Contributor

bucko13 commented Feb 27, 2024

Hi @hwinsby!

I'm so sorry I let this hang for so long. I've been working to get all the open source code migrated over to a new monorepo. I believe this will make the development experience much smoother, especially if you want to start digging into any of the bitcoin libraries as well. Good news is that I suspect that most of your changes here should be transferrable to the new code base though, so hopefully that's not too much trouble. I'll hold off on reviewing until it's in the new repo so we keep any conversation logs.

To get started just clone https://github.com/caravan-bitcoin/caravan, install dependencies and run npx turbo run dev (or install turbo globally. You'll see the coordinator app in apps/coordinator and the rest of the code in there should be pretty familiar. Please let me know if you run into any bumps in the developer experience (or submit a PR with readme updates). I definitely am hoping it's as smooth a transition as possible and ideally easier to work with!

@bucko13 bucko13 closed this Feb 27, 2024
@hwinsby
Copy link
Contributor Author

hwinsby commented Apr 4, 2024

Hey @bucko13, I'm so sorry for the late response here! I'm hoping to get working on this next week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants