Occurences of 'innerText' were replaced with 'textContent' #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…les excluding external libraries
|
@unconed - i know from the discussion in #21 that you are currently rewriting the library and this branch is eventually going to be deprecated. Just to confirm my expectations: do you expect to perform any additional merges in the current branch (and to review this pull request as part of it)? Thanks. |
|
Sure, I've just been busy the past few weeks. Bugfixes can definitely go in, I'm still using the library too. TextContent works in all the browsers I care about, so this seems legit. |
unconed
added a commit
that referenced
this pull request
Mar 28, 2014
Occurences of 'innerText' were replaced with 'textContent'
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occurences of 'innerText' were replaced with 'textContent' for all files excluding external libraries.
This fix improves compatibility with IE11 by utilizing “textContent”, a W3C standard API. innerText logic handles newlines differently in different browsers, which can cause shader compilation problems.