Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New check for namespace should not be used #24

Closed
wants to merge 12 commits into from
Closed

New check for namespace should not be used #24

wants to merge 12 commits into from

Conversation

lucasjct
Copy link
Contributor

@lucasjct lucasjct commented Nov 27, 2023 •
edited
Loading

Description

  1. Created a table for centralize all checks presents on the Marvin.
  2. Added new check for namespace should not be used related with CIS documentation page 282.

How has this been tested?

Run make test

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@lucasjct lucasjct added the documentation Improvements or additions to documentation label Nov 27, 2023
@CLAassistant
Copy link

CLAassistant commented Nov 27, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

matheusfm
matheusfm requested changes Nov 28, 2023
View reviewed changes
checks.md Outdated Show resolved Hide resolved
checks.md Outdated Show resolved Hide resolved
checks.md Outdated Show resolved Hide resolved
internal/builtins/cis/M-500_default_namespace_test.yaml Outdated Show resolved Hide resolved
lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change message for: Workloads in default namespace

lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed framework names

@lucasjct lucasjct self-assigned this Nov 28, 2023
lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove 'resources' extra.

lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review all changes.

lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add general checks in table.

lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved

lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change done

lucasjct
lucasjct commented Nov 28, 2023
View reviewed changes
Copy link
Contributor Author

@lucasjct lucasjct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table content

@lucasjct lucasjct closed this Nov 28, 2023
@lucasjct lucasjct deleted the add-new-check branch November 28, 2023 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusfm matheusfm matheusfm approved these changes

Assignees

@lucasjct lucasjct

Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasjct @CLAassistant @matheusfm