Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checks for sudo in container entrypoint & registry deprecated #28

Merged
merged 1 commit into from
Dec 5, 2023
Merged

checks for sudo in container entrypoint & registry deprecated #28

merged 1 commit into from
Dec 5, 2023

Conversation

lucasjct
Copy link
Contributor

@lucasjct lucasjct commented Dec 5, 2023

Description

Created checks for:

  • sudo in container entrypoint;
  • image with registry deprecated .

Both was added in general session.

How has this been tested?

  • run make test for unit test
  • 1) create a deployment and 2) run checks with marvin: marvin scan --disable-builtin --checks ./internal/builtins/general/M-408_sudo_container_entrypoint.yaml check the results and 3) run marvin scan --disable-builtin --checks ./internal/builtins/general/M-409_deprecated_image_registry.yaml, finally check the results.

Checklist

  • I have labeled this PR with the relevant Type labels
  • I have documented my code (if applicable)
  • My changes are covered by tests

@lucasjct lucasjct added the enhancement New feature or request label Dec 5, 2023
@lucasjct lucasjct merged commit 9d968c6 into main Dec 5, 2023
4 checks passed
@lucasjct lucasjct deleted the new-check-for-marvin branch December 5, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matheusfm matheusfm matheusfm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucasjct @matheusfm