Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dependency scripture-resources-rcl #1653

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Jan 14, 2025

Describe what your pull request addresses (Please include relevant issue numbers):

  • This updates scripture-resources-rcl dependency, which fixes bug with finding quotes occurrences for highlighting. When the occurrence is set to +1 and the requested quotes is a group of quotes separated by ampersand.

New behavior: finds the requested occurrence of the first quote and looks for the next first matching occurring of the rest of the quotes (the quotes after the first ampersand).

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Is the repo documentation accurate/appropriate?
    • Check Stylguidist if applicable
    • Check readme for correct information about the feature being worked on
  • Check that there are not inadvertent commits
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story

@abelpz abelpz merged commit f6e1a43 into develop Jan 14, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant