Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Enhancements: Optional Features and Visual Clarity Improvements #1659

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

abelpz
Copy link
Member

@abelpz abelpz commented Jan 27, 2025

Describe what your pull request addresses (Please include relevant issue numbers):

UI Enhancements: Optional Features and Visual Clarity Improvements

Key Changes:

  1. Enhanced Visual Separation

    • Improved visual boundaries between notes/questions
    • Better distinction between consecutive entries
    • Clearer content hierarchy and readability
  2. Scripture Row Header Optimizations

    • Added toggle in main menu for rendering optimization
    • Benefits:
      • If active: Faster initial load time (2-3 seconds)
      • If not active: Eliminates scroll "wiggle" effect (wiggle has been improved with this PR but still exists)
    • Users can choose between:
      • Optimized rendering (with slight wiggle while scrolling through notes)
      • Standard rendering (slower initial load, no wiggle)
  3. Configurable Sticky Headers

    • New toggle button in TSV Table toolbar for tNotes and tQuestions
    • Features:
      • Sticky Mode: Keeps scripture visible while scrolling within notes
      • Standard Mode: Traditional scrolling behavior
    • Addresses user feedback about navigation confusion during scrolling

User Impact:

  • More control over UI behavior
  • Better performance options
  • Improved visual clarity
  • Enhanced user experience customization

Technical Notes:

  • All features are opt-in/opt-out
  • Settings persist across sessions
  • No impact on core functionality

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Is the repo documentation accurate/appropriate?
    • Check Stylguidist if applicable
    • Check readme for correct information about the feature being worked on
  • Check that there are not inadvertent commits
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story

@abelpz abelpz changed the title Abelpz/improve tsv UI UI Enhancements: Optional Features and Visual Clarity Improvements Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant