Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix mcleanb 7546 fix verse span support #7549

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Bugfix mcleanb 7546 fix verse span support #7549

merged 5 commits into from
Nov 7, 2023

Conversation

PhotoNomad0
Copy link
Contributor

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

@PhotoNomad0 PhotoNomad0 changed the base branch from develop to release-v3.6.1 November 7, 2023 16:20
@PhotoNomad0 PhotoNomad0 marked this pull request as ready for review November 7, 2023 16:37
@PhotoNomad0 PhotoNomad0 merged commit 81a42f9 into release-v3.6.1 Nov 7, 2023
7 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bugfix-mcleanb-7546-fixVerseSpanSupport branch November 7, 2023 16:39
PhotoNomad0 added a commit that referenced this pull request Nov 8, 2023
@PhotoNomad0
Merge changelog release 3.6.2 (#7557)
e56071c 
* bugfix 7546 / fix creating WA group data - allow for verses to be string format (#7547)

* fix creating WA group data - allow for verses to be string format

* add warning when group data is generated and verse span is not found

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Bugfix mcleanb 7546 fix verse span support (#7549)

* fix creating WA group data - allow for verses to be string format

* add warning when group data is generated and verse span is not found

* add unit tests to check for verse span in WA group data

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Bugfix 7555 / multiselect bug (#7556)

* add python script to get latest

* add javascript to get latest

* add javascript to get latest versions of tCore

* change default upgrade of macos arm64 to universal

* got getLatestTcore.js working.  fixed versioning in getLatestTcore.py

* update unit tests for arm64 update

* update unit tests

* update wordAlignment

* update wordAlignment

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* update wordAlignment

---------

Co-authored-by: PhotoNomad0 <[email protected]>
PhotoNomad0 added a commit that referenced this pull request Nov 8, 2023
@PhotoNomad0
Feature 7552 / download right version (#7553)
0546c47 
* add python script to get latest

* add javascript to get latest

* add javascript to get latest versions of tCore

* change default upgrade of macos arm64 to universal

* got getLatestTcore.js working.  fixed versioning in getLatestTcore.py

* update unit tests for arm64 update

* Merge changelog release 3.6.2 (#7557)

* bugfix 7546 / fix creating WA group data - allow for verses to be string format (#7547)

* fix creating WA group data - allow for verses to be string format

* add warning when group data is generated and verse span is not found

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Bugfix mcleanb 7546 fix verse span support (#7549)

* fix creating WA group data - allow for verses to be string format

* add warning when group data is generated and verse span is not found

* add unit tests to check for verse span in WA group data

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Bugfix 7555 / multiselect bug (#7556)

* add python script to get latest

* add javascript to get latest

* add javascript to get latest versions of tCore

* change default upgrade of macos arm64 to universal

* got getLatestTcore.js working.  fixed versioning in getLatestTcore.py

* update unit tests for arm64 update

* update unit tests

* update wordAlignment

* update wordAlignment

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* update wordAlignment

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* add python script to get latest

* add javascript to get latest

* add javascript to get latest versions of tCore

* got getLatestTcore.js working.  fixed versioning in getLatestTcore.py

---------

Co-authored-by: PhotoNomad0 <[email protected]>
PhotoNomad0 added a commit that referenced this pull request Nov 9, 2023
@PhotoNomad0
Merge release 3.6.2 into master (#7558)
443db56 
* update change log

* add jsdoc generation to github actions

* fix jsdocs generation

* fix jsdocs generation. fix some jsdocs

* fix jsdocs generation. fix some jsdocs.

* fix jsdocs folder name

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* adding git commit of jsdocs

* working on adding jsDocs to github pages

* README.md cleanup

* README.md cleanup

* remove the git version update code which does not succeed.

* fix github actions

* cleanup github actions

* fix git commit of jsdocs

* fix git commit of jsdocs

* updated container

* tweak logging

* back out fix the npm cache

* fix for committing jsdocs

* fix for build errors

* fix for build errors

* fix for build errors

* create output folder with permissions

* create output folder with permissions

* fix for test errors

* fix for test errors

* fix for test errors

* fix for test errors

* fix access errors for js docs

* fix access errors for js docs

* fix chapter justification for ltr languages.

* update to 3.5.1

* fix jsdocs generation - need permission to write to docs folder

* fix jsdocs generation - need permission to write to docs folder

* fix jsdocs generation - need permission to write to docs folder

* comments

* removed push of jsdocs changes back into branch

* fix access errors for js docs

* update change log

* update change log

* fix access errors for js docs

* updated docker container

* exclude test folder.

* fix for test failure

* fix for test failure

* fix for test failure

* fix for test failure

* fix for test failure

* Feature / update electronite to v25.3.2 (#7530)

* trying updated electronite

* testing

* trying updated electronite

* update to use electronite 25.3.2

* update to use electronite 23.3.10

---------

Co-authored-by: blm <[email protected]>

* feature / updated tc-source-content-updater to use the latest catalog URLs (#7531)

* updated tc-source-content-updater to use the latest catalog URLs

* bump version

---------

Co-authored-by: blm <[email protected]>

* Feature / fix URL for catalog (#7532)

* updated tc-source-content-updater to use the latest catalog URLs

* bump version

* bump version

* updated tc-source-content-updater to use the latest catalog URLs

* Revert "bump version"

This reverts commit 80fbb45.

* bump version

* bump version

* updated tc-source-content-updater to use the latest catalog URLs

* updated tc-source-content-updater to use the latest catalog URLs

* updated tc-source-content-updater to use the latest catalog URLs

* updated resources

---------

Co-authored-by: blm <[email protected]>

* Bugfix 7533/broken preview paragraph (#7534)

* fix charis definition

* fix print preview for case missing paragraph marker before

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Feature 7536 / front matter alignment support (#7538)

* fixes for front matter alignment

* update resources

* fix to migrate original language bible on upgrade of version.
fix to export front matter alignments

* fix migration unit tests to match replacement of original language bibles parsed with older tC versions.

* fix migration to remove derived original language translationWords.

* Clean up highlight colors in log file.

* Clean up

* bump version

* updated dependencies

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Feature 5885 / alignment enhancements (#7542)

* updated word alignment tool

* updated locales

* updated translation helps tools

* updated tools

* updated tools

* updated tools

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* updated CHANGELOG.md (#7544)

Co-authored-by: PhotoNomad0 <[email protected]>

* bugfix 7546 / fix creating WA group data - allow for verses to be string format (#7547)

* fix creating WA group data - allow for verses to be string format

* add warning when group data is generated and verse span is not found

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Bugfix mcleanb 7546 fix verse span support (#7549)

* fix creating WA group data - allow for verses to be string format

* add warning when group data is generated and verse span is not found

* add unit tests to check for verse span in WA group data

---------

Co-authored-by: PhotoNomad0 <[email protected]>

* Bugfix 7555 / multiselect bug (#7556)

* add python script to get latest

* add javascript to get latest

* add javascript to get latest versions of tCore

* change default upgrade of macos arm64 to universal

* got getLatestTcore.js working.  fixed versioning in getLatestTcore.py

* update unit tests for arm64 update

* update unit tests

* update wordAlignment

* update wordAlignment

---------

Co-authored-by: PhotoNomad0 <[email protected]>

---------

Co-authored-by: blm <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@PhotoNomad0