Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loading with paths #46

Closed
behinger opened this issue Jul 4, 2023 · 4 comments · Fixed by #71
Closed

loading with paths #46

behinger opened this issue Jul 4, 2023 · 4 comments · Fixed by #71
Labels
bug Something isn't working

Comments

@behinger
Copy link
Member

behinger commented Jul 4, 2023

I got lots of errors with loading in more complex environments

E.g. it tries to read empty folders, ".git" folders, it throws errors if a file has no extension either :S


there is also quite some code doubling, I dont want to get too knee deep in there, but once the code doubling is addressed, this becomes easier to debug?

@behinger
Copy link
Member Author

behinger commented Jul 4, 2023

ah sorry - ok, I understand now what happened. I had to put the ".git" in the excludeFolder; maybe a good idea to exclude all secret ".secret" folders by defaul?

@ReneSkukies
Copy link
Member

Yes, we should think about this. Becomes quite the conditional statement already though...

@ReneSkukies
Copy link
Member

I can have a look at how BIDS.jl used to do it and revise a bit

@ReneSkukies ReneSkukies added the bug Something isn't working label Jan 24, 2024
@ReneSkukies ReneSkukies linked a pull request Mar 27, 2024 that will close this issue
@ReneSkukies
Copy link
Member

Fixedw with continuables

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants