add continuables.jl for loading paths #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Loading the paths was a bottle neck so far, this should make file look up much faster
ReneSkukies
added
bug
This was
linked to
issues
Mar 27, 2024
Closed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #71 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 4 4
Lines 217 247 +30
=====================================
- Misses 217 247 +30 ☔ View full report in Codecov by Sentry. |
behinger
reviewed
Apr 2, 2024
Because of renaming and kicking out the root path loading broke, tests should be implemented next...; If no files are found or the path does not exists there will now be an error instead of an empty returned DF
|
ready to merge !
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Loading the paths was a bottle neck so far, this should make file lookup much faster. Additionally, that fixes a bug during loading and makes the code much more readable