Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plot_butterfly: expose all configuration options for topoplot #183

Closed
behinger opened this issue Jun 1, 2024 · 5 comments
Closed

plot_butterfly: expose all configuration options for topoplot #183

behinger opened this issue Jun 1, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@behinger
Copy link
Member

behinger commented Jun 1, 2024

It would be great, if we could just add custom options to the butterfly topoplot inset

@vladdez
Copy link
Collaborator

vladdez commented Jun 13, 2024

I added topohalign, topovalign, topoaspect
Anything else?

@behinger
Copy link
Member Author

why not have a topo_config = NamedTuple() argument and you can just provide any arbitrary option you want?

@vladdez
Copy link
Collaborator

vladdez commented Jun 13, 2024

How it should be implemented? this way?
image

@behinger
Copy link
Member Author

Yes! The defaults could be pushed to plotconfig

vladdez added a commit that referenced this issue Jun 17, 2024
facetting and circular allignment

- #49 fixed
- #182 fixed
- #183 partially fixed
- new selling points added
- compatibility with new Makie version
- attempts to implement plot_dm with hierarchical labels

Toposeries
- bin_width instead of Δbin, bin_num, nrows as parameters added
- code reformatting: big function into smaller functions
- col_labels = true  as deafult

Tests
- several tests for error managment
- tests for topoplotseries are divided on simple and advanced
@vladdez vladdez added the enhancement New feature or request label Sep 13, 2024
@vladdez
Copy link
Collaborator

vladdez commented Sep 23, 2024

#237 at least infrastructure is implemented

@vladdez vladdez closed this as completed Sep 23, 2024
vladdez added a commit that referenced this issue Sep 24, 2024
Splines and plot_erp

Fixed:
- #231 
- #235
- #225 - this parameter was deprecated at all
- #234 
- remove `legend.tellwidth = false` from the plotconfgs - better layout
- #55 and #238
- #216
- #56
- #232
- #172 
- #222
- #236 
- #205 
- partially #94 
- #106 
- #183 
- #141 
- #147 

Spline plot 
- #36 - here we added a new type of plot plot_splines
- knots with dashed line
- subplots for each spline term
- documentation page and config

Also
- system of supportive axis available for users to change
- opportunity to put them into docstrings via substitution
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants