-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
facetting and circular allignment #180
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #180 +/- ##
==========================================
- Coverage 87.78% 87.14% -0.64%
==========================================
Files 18 18
Lines 753 856 +103
==========================================
+ Hits 661 746 +85
- Misses 92 110 +18 ☔ View full report in Codecov by Sentry. |
this PR is just too huge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skipped checking the tests
Given that the PR doesn't work yet, maybe you can simply make a new PR on this PR?
Project.toml
Outdated
@@ -23,6 +23,7 @@ MakieThemes = "e296ed71-da82-5faf-88ab-0034a9761098" | |||
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf" | |||
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" | |||
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2" | |||
StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is very unlikely that you need stats base and statistics. Better to choose one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i used StatsBase for debugging
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
then it doesnt need to be in the project.toml
Toposeries
Tests