Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

facetting and circular allignment #180

Merged
merged 34 commits into from
Jun 17, 2024
Merged

facetting and circular allignment #180

merged 34 commits into from
Jun 17, 2024

Conversation

vladdez
Copy link
Collaborator

@vladdez vladdez commented May 21, 2024

Toposeries

  • bin_width instead of Δbin, bin_num, nrows as parameters added
  • code reformatting: big function into smaller functions
  • col_labels = true as deafult

Tests

  • several tests for error managment
  • tests for topoplotseries are divided on simple and advanced

src/plot_circular_topoplots.jl Outdated Show resolved Hide resolved
src/plot_circular_topoplots.jl Outdated Show resolved Hide resolved
src/plot_circular_topoplots.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
test/test_toposeries.jl Outdated Show resolved Hide resolved
Copy link

codecov bot commented May 27, 2024

Codecov Report

Attention: Patch coverage is 88.19444% with 17 lines in your changes missing coverage. Please review.

Project coverage is 87.14%. Comparing base (aefcb7f) to head (5f24e32).
Report is 78 commits behind head on main.

Current head 5f24e32 differs from pull request most recent head f5598b0

Please upload reports for the commit f5598b0 to get more accurate results.

Files Patch % Lines
src/eeg_series.jl 79.16% 10 Missing ⚠️
src/plot_designmatrix.jl 86.66% 4 Missing ⚠️
src/plot_topoplotseries.jl 96.42% 2 Missing ⚠️
src/plot_erp.jl 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #180      +/-   ##
==========================================
- Coverage   87.78%   87.14%   -0.64%     
==========================================
  Files          18       18              
  Lines         753      856     +103     
==========================================
+ Hits          661      746      +85     
- Misses         92      110      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

test/test_erpimage.jl Outdated Show resolved Hide resolved
test/test_erpimage.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
src/plotconfig.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
test/test_toposeries.jl Outdated Show resolved Hide resolved
test/test_toposeries.jl Outdated Show resolved Hide resolved
test/test_toposeries.jl Outdated Show resolved Hide resolved
test/test_toposeries.jl Outdated Show resolved Hide resolved
test/test_toposeries1.jl Outdated Show resolved Hide resolved
test/test_toposeries2.jl Outdated Show resolved Hide resolved
test/test_toposeries2.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
src/eeg_series.jl Outdated Show resolved Hide resolved
@vladdez vladdez mentioned this pull request Jun 13, 2024
@vladdez vladdez requested a review from behinger June 13, 2024 17:50
@vladdez
Copy link
Collaborator Author

vladdez commented Jun 13, 2024

this PR is just too huge
although some problems are yet not solved (multirow categorical toposeries)

Copy link
Member

@behinger behinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skipped checking the tests

Given that the PR doesn't work yet, maybe you can simply make a new PR on this PR?

Project.toml Outdated
@@ -23,6 +23,7 @@ MakieThemes = "e296ed71-da82-5faf-88ab-0034a9761098"
SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
Statistics = "10745b16-79ce-11e8-11f9-7d13ad32a3b2"
StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is very unlikely that you need stats base and statistics. Better to choose one

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i used StatsBase for debugging

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

then it doesnt need to be in the project.toml

docs/literate/how_to/mult_vis_in_fig.jl Show resolved Hide resolved
docs/literate/tutorials/erp_grid.jl Outdated Show resolved Hide resolved
docs/make.jl Show resolved Hide resolved
docs/src/index.md Show resolved Hide resolved
src/plot_topoplotseries.jl Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plot_topoplotseries.jl Show resolved Hide resolved
src/plot_topoplotseries.jl Outdated Show resolved Hide resolved
src/plotconfig.jl Outdated Show resolved Hide resolved
@vladdez vladdez merged commit 99d6f58 into main Jun 17, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants