Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug in toposeries #57

Merged
merged 5 commits into from
Aug 3, 2023
Merged

bug in toposeries #57

merged 5 commits into from
Aug 3, 2023

Conversation

vladdez
Copy link
Collaborator

@vladdez vladdez commented Aug 3, 2023

No description provided.

@behinger
Copy link
Member

behinger commented Aug 3, 2023

🎉 thanks for fixing! if you are ready tell me

Two tipps for next time:

    • you can also create a PR in draft mode, and put it out of draft mode if you are ready to merge
  1. in the future you might want to choose a new branch for a new bugfix :)

@codecov-commenter
Copy link

Codecov Report

Merging #57 (34ffe33) into main (27dc7fd) will increase coverage by 9.93%.
The diff coverage is 83.33%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #57      +/-   ##
==========================================
+ Coverage   12.47%   22.41%   +9.93%     
==========================================
  Files          15       15              
  Lines         529      531       +2     
==========================================
+ Hits           66      119      +53     
+ Misses        463      412      -51     
Files Changed Coverage Δ
src/plot_topoplotseries.jl 90.90% <83.33%> (+90.90%) ⬆️

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vladdez vladdez merged commit e18b5f9 into main Aug 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants