Update CI.yml #62
Update CI.yml #62
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #62 +/- ##
=======================================
Coverage 69.74% 69.74%
=======================================
Files 10 10
Lines 314 314
=======================================
Hits 219 219
Misses 95 95 ☔ View full report in Codecov by Sentry. |
|
Okay, with Julia 1.9 it works. So it seems to be the interplay between Julia 1.10 and Documenter.jl as suggested in this issue. |
|
I also identified the example block which causes the issue: which is apparently a problem since the example block only contains a comment. Therefore, I will remove this comment and set the Julia version back to '1'. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
| @@ -276,6 +276,4 @@ end | |||
| # - if `offset` > `length(signal.basis)` -> no overlap | |||
| # - if `offset` < `length(signal.basis)` -> there might be overlap, depending on the other parameters of the onset distribution | |||
|
|
|||
|
|
|||
| ## Footnotes # hide | |||
| # [^1]: Wikipedia contributors. (2023, December 5). Log-normal distribution. In Wikipedia, The Free Encyclopedia. Retrieved 12:27, December 7, 2023, from https://en.wikipedia.org/w/index.php?title=Log-normal_distribution&oldid=1188400077# | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
| # [^1]: Wikipedia contributors. (2023, December 5). Log-normal distribution. In Wikipedia, The Free Encyclopedia. Retrieved 12:27, December 7, 2023, from https://en.wikipedia.org/w/index.php?title=Log-normal_distribution&oldid=1188400077# | |
| # [^1]: Wikipedia contributors. (2023, December 5). Log-normal distribution. In Wikipedia, The Free Encyclopedia. Retrieved 12:27, December 7, 2023, from https://en.wikipedia.org/w/index.php?title=Log-normal_distribution&oldid=1188400077# |
There was a problem hiding this comment.
@behinger Apparently, the single quotes in the .yml file were changed to double quotes in my VSCode (because I have auto-formatting enabled). Do you think that's fine or shall I change them back?
|
Yeah, CI seems to work again. @behinger could you quickly have a look at the PR and merge it if everything is fine? |
|
I dont see where you fix it to 1.9 - should the "1" be "1.9" then? |
This was only temporary to debug whether the Julia version was related to the issue. |
Trying to fix failing CI for documentation.
Changed Julia version from "1" to "1.9".