Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Ruff #142

Merged
merged 2 commits into from
Feb 26, 2025
Merged

Switch to Ruff #142

merged 2 commits into from
Feb 26, 2025

Conversation

srugano
Copy link
Contributor

@srugano srugano commented Feb 26, 2025

No description provided.

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 57.89474% with 24 lines in your changes missing coverage. Please review.

Project coverage is 70.73%. Comparing base (b394cb8) to head (88507ee).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
...hope_dedup_engine/apps/faces/managers/file_sync.py 16.66% 5 Missing ⚠️
...hope_dedup_engine/apps/api/models/deduplication.py 55.55% 4 Missing ⚠️
src/hope_dedup_engine/apps/api/utils/progress.py 0.00% 2 Missing ⚠️
src/hope_dedup_engine/apps/api/views.py 75.00% 2 Missing ⚠️
src/hope_dedup_engine/apps/api/auth.py 0.00% 1 Missing ⚠️
...pe_dedup_engine/apps/api/deduplication/adapters.py 0.00% 1 Missing ⚠️
...ope_dedup_engine/apps/api/deduplication/process.py 0.00% 1 Missing ⚠️
...pe_dedup_engine/apps/api/deduplication/registry.py 0.00% 1 Missing ⚠️
src/hope_dedup_engine/apps/api/validators.py 0.00% 1 Missing ⚠️
...dedup_engine/apps/core/management/commands/demo.py 75.00% 1 Missing ⚠️
... and 5 more
Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #142   +/-   ##
========================================
  Coverage    70.73%   70.73%           
========================================
  Files           77       77           
  Lines         1534     1534           
  Branches        80       80           
========================================
  Hits          1085     1085           
  Misses         444      444           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


additional_dependencies: [flake8-bugbear==22.9.23]
stages: [ pre-commit ]
- id: isort
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this needed?

@domdinicola domdinicola merged commit aa5ed01 into develop Feb 26, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants