Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long term // REST API #4639

Draft
wants to merge 235 commits into
base: develop
Choose a base branch
from
Draft

Long term // REST API #4639

wants to merge 235 commits into from

Conversation

pavlo-mk
Copy link
Contributor

@pavlo-mk pavlo-mk commented Feb 19, 2025

Long term branch for REST API

❗ please merge back develop and permissions-rework-nov24 into that branch every day ❗

❗ ❗ Please create NEW TASK in the EPIC AB#210007: DRF endpoints❗ ❗
TODO List:

  • Move to REST core queries:
    • Profile (old GQL query Me) [in-progress] ... Pavlo ... 📊 📈 👨‍🍳 AB#236631
    • All_BA (old GQL query AllBusinessAreas)
    • BA_Data (old GQL query BusinessAreaData)
    • query ProgrammeChoiceData
    • query AllProgramsForChoices
    • query AllProgramsForTable
    • etc.
  • Move Page by Page to REST:
    • Programme
    • Targeting
    • Payment Module
    • Grievances (huge)
    • RDI?
  • Targeting refactors
    • we don’t refactor it at this level to REST. We will do it as whole Payment Module refactor

pkujawa and others added 30 commits November 6, 2024 00:32
Rename UserRole -> RoleAssignment
Test model constraints
… on account models, apply new logic for rest, some graphql requests
…gnments with validation against allowed BAs, tests
…ixtures for the user and partner permissions
… specific scope for ftontend, additional model constraints
Copy link

codecov bot commented Feb 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (c1407de) to head (040ebe6).
Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4639      +/-   ##
===========================================
- Coverage    85.85%   84.60%   -1.26%     
===========================================
  Files          551      558       +7     
  Lines        36018    36401     +383     
===========================================
- Hits         30924    30796     -128     
- Misses        5094     5605     +511     
Flag Coverage Δ
e2e ?
unittests 84.60% <ø> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

pavlo-mk and others added 28 commits February 24, 2025 14:35
remove existing jest tests + snapshots + fixtures
* change migration to rename model instead of creating new one

* fix business_areas query on user

* fix unicef users migration for cases with roles in global
mock beneficiary groups list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants