-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Long term // REST API #4639
Draft
pavlo-mk
wants to merge
235
commits into
develop
Choose a base branch
from
long-term-branch/rest-api
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Long term // REST API #4639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename UserRole -> RoleAssignment Test model constraints
… on account models, apply new logic for rest, some graphql requests
…k with new model, modify tests
…gnments with validation against allowed BAs, tests
… role_assignments and partners, tests
…ixtures for the user and partner permissions
… specific scope for ftontend, additional model constraints
… for roles on Partner creation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #4639 +/- ##
===========================================
- Coverage 85.85% 84.60% -1.26%
===========================================
Files 551 558 +7
Lines 36018 36401 +383
===========================================
- Hits 30924 30796 -128
- Misses 5094 5605 +511
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…long-term-branch/rest-api
remove existing jest tests + snapshots + fixtures
* change migration to rename model instead of creating new one * fix business_areas query on user * fix unicef users migration for cases with roles in global
Remove jest set up new
tests set up update
mock beneficiary groups list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Long term branch for REST API
❗ please merge back
develop
andpermissions-rework-nov24
into that branch every day ❗❗ ❗ Please create NEW TASK in the EPIC AB#210007: DRF endpoints❗ ❗
TODO List:
query Me
) [in-progress] ... Pavlo ... 📊 📈 👨🍳 AB#236631query AllBusinessAreas
)query BusinessAreaData
)