Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix e2e Create TP #4655

Merged
merged 7 commits into from
Mar 3, 2025
Merged

Fix e2e Create TP #4655

merged 7 commits into from
Mar 3, 2025

Conversation

pavlo-mk
Copy link
Contributor

AB#237264: Fix very unstable E2E test TestCreateTargeting.test_create_targeting_with_pdu_null_criteria

@pavlo-mk pavlo-mk added the work in progress Change doesn't need to be reviewed label Feb 27, 2025
@pavlo-mk pavlo-mk self-assigned this Feb 27, 2025
Copy link

codecov bot commented Feb 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (4bd425d) to head (36d5017).
Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4655   +/-   ##
=======================================
  Coverage   85.83%   85.83%           
=======================================
  Files         547      547           
  Lines       35998    35998           
=======================================
  Hits        30898    30898           
  Misses       5100     5100           
Flag Coverage Δ
e2e 60.89% <ø> (ø)
unittests 84.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pavlo-mk pavlo-mk marked this pull request as ready for review February 27, 2025 17:45
@pavlo-mk pavlo-mk removed the work in progress Change doesn't need to be reviewed label Feb 27, 2025
@pavlo-mk pavlo-mk changed the title WIP // Fix e2e Create TP Fix e2e Create TP Feb 27, 2025
@johniak johniak merged commit 2e452e8 into master Mar 3, 2025
13 checks passed
@johniak johniak deleted the fix_e2e_create_tp branch March 3, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants