Admin for universal update script #4663
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #4663 +/- ##
===========================================
+ Coverage 84.32% 86.02% +1.70%
===========================================
Files 547 556 +9
Lines 35996 36668 +672
===========================================
+ Hits 30352 31542 +1190
+ Misses 5644 5126 -518
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pavlo-mk
approved these changes
Feb 28, 2025
pkujawa
approved these changes
Mar 3, 2025
| if value is None and self.allow_multiple_selected: | ||
| return [] | ||
| elif self.allow_multiple_selected: | ||
| processed_value = [v for v in value.split(",")] |
| elif self.allow_multiple_selected: | ||
| processed_value = [v for v in value.split(",")] | ||
|
|
||
| if not isinstance(value, (tuple, list)): |
There was a problem hiding this comment.
then value typing is incorrect
pkujawa
reviewed
Mar 3, 2025
Comment on lines
+46
to
+54
| db_count = Individual.objects.filter(unicef_id__in=unicef_ids, program_id=program_id).count() | ||
| if db_count != len(unicef_ids): | ||
| unicef_ids_from_db = list( # pragma: no cover | ||
| Individual.objects.filter(unicef_id__in=unicef_ids, program_id=program_id).values_list( | ||
| "unicef_id", flat=True | ||
| ) | ||
| ) | ||
| diff = set(unicef_ids) - set(unicef_ids_from_db) # pragma: no cover | ||
| raise Exception("Some unicef ids are not in the program: " + str(diff)) # pragma: no cover |
There was a problem hiding this comment.
there is a lot of pragmas, this case could be tested :D
pkujawa
reviewed
Mar 3, 2025
Comment on lines
+133
to
+160
| if self.individual_flex_fields is None: | ||
| return [] # pragma: no cover | ||
| for field, (name, validator, _handler) in self.individual_flex_fields.items(): | ||
| value = row[headers.index(field)] | ||
| error = validator(value, name, row, self.business_area, self.program) | ||
| if error: # pragma: no cover | ||
| errors.append(f"Row: {row_index} - {error}") | ||
| return errors | ||
|
|
||
| def validate_household_flex_fields( | ||
| self, row: Tuple[Any, ...], headers: List[str], individual: Individual, row_index: int | ||
| ) -> List[str]: | ||
| errors = [] | ||
| if self.household_flex_fields is None: | ||
| return [] # pragma: no cover | ||
| for field, (name, validator, _handler) in self.household_flex_fields.items(): | ||
| value = row[headers.index(field)] | ||
| error = validator(value, name, row, self.business_area, self.program) | ||
| if error: # pragma: no cover | ||
| errors.append(f"Row: {row_index} - {error}") | ||
| return errors | ||
|
|
||
| def validate_documents( | ||
| self, row: Tuple[Any, ...], headers: List[str], individual: Individual, row_index: int | ||
| ) -> List[str]: | ||
| if self.document_fields is None: | ||
| return [] # pragma: no cover | ||
| errors = [] |
There was a problem hiding this comment.
Some of the validations also could be tested not to spam with the pragmas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AB#237765
This pull request introduces significant changes to the
universal_update_scriptfunctionality, including new models, admin configurations, and Celery tasks. The most important changes include the addition of theUniversalUpdatemodel, the creation of admin forms and views for managing universal updates, and the implementation of Celery tasks for handling update processes.Universal Update Script Enhancements:
New Model:
src/hct_mis_api/apps/universal_update_script/models.py: Added theUniversalUpdatemodel to manage universal update processes, including fields for individual and household data, document types, and delivery mechanisms.Admin Configuration:
src/hct_mis_api/apps/universal_update_script/admin.py: Created admin forms and views for theUniversalUpdatemodel, including dynamic field choices and custom buttons for generating templates and starting update tasks.Celery Tasks:
src/hct_mis_api/apps/universal_update_script/celery_tasks.py: Implemented Celery tasks for running universal individual updates and generating update templates, with logging and error handling.Other Changes:
App Configuration:
src/hct_mis_api/apps/universal_update_script/apps.py: Added theAppConfigfor theuniversal_update_scriptapp.Database Migration:
src/hct_mis_api/apps/universal_update_script/migrations/0001_migration.py: Created the initial migration for theUniversalUpdatemodel, setting up the database schema.