Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-17754 added Samogitian language #3818

Open
wants to merge 1 commit into
base: _ddl/v47
Choose a base branch
from

Conversation

zordsdavini
Copy link

CLDR-17754

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@CLAassistant
Copy link

CLAassistant commented Jun 21, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@conradarcturus conradarcturus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's really exciting to see this language added to CLDR :D Instead of adding everything all at once -- let's do it incrementally. See this pull request where I'm just adding the core data for Haitian Creole: #3948 -- Can you trim off most of the changes to sgs.xml in this diff to just the code data?

Once it's in the system we can contribute the time values in the Survey tool in the v47 window later this fall -- that tool has lots of assistance including validation.

Collation and casing and probably fine to add in this diff. I'm not so familiar w/ that code myself but it should generally be fine.

Also there are some other validation errors like that the pull request & commit should start w/ your Jira Ticket number. The Jira ticket does need to get reviewed but I tagged it so it should get review now.

common/main/sgs.xml Outdated Show resolved Hide resolved
common/supplemental/plurals.xml Show resolved Hide resolved
@zordsdavini zordsdavini changed the title added Samogitian language CLDR-17754: added Samogitian language Aug 11, 2024
@zordsdavini
Copy link
Author

I checked errors and have problem

/home/runner/work/cldr/cldr/common/main/sgs.xml:18:110: error
sgs [Samogitian]	error	▸Core_Data|Alphabetic_Information|Characters_in_Use|Main_Letters◂	〈[a b c d e f g h i j k l m n o p q r s t u v w x y z]〉	【】	〈[aā b c č d eē ėė̄ f g h iī j k l m n oō p r s š t uū v z ž]〉	«=»	【】	⁅illegal characters in exemplars⁆	❮Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0304]‎❯	https://st.unicode.org/cldr-apps/v#/sgs//7ed88347aa1b55ed
Error:  Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0304]‎

We have letter "ė̄" (ė with macron or e with dot above and macron), ex.: gerė̄jē. Mostly we write it with ė and adding macron (\u0304). Unicode doesn't have such single letter and didn't want to add when we asked to do that. What should we do here?
And we have keylayout with macron as separate key, so all ā, ē, ī, ō, ė̄, ū we can write in combination with \u0304

@macchiati
Copy link
Member

macchiati commented Aug 12, 2024 via email

@srl295 srl295 changed the base branch from main to ddl/v47 August 20, 2024 19:25
@srl295 srl295 added the ddl DDL-SC specific work label Aug 20, 2024
zordsdavini added a commit to zordsdavini/cldr that referenced this pull request Aug 21, 2024
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@zordsdavini
Copy link
Author

Should I add something more or do something because of failed build? The error looks very unrelated but maybe I am wrong?

@DavidLRowe
Copy link
Contributor

@srl295 Can you advise on test failures being reported here?

@srl295 srl295 self-assigned this Sep 16, 2024
@srl295 srl295 deleted the branch unicode-org:_ddl/v47 October 25, 2024 16:35
@srl295 srl295 closed this Oct 25, 2024
@zordsdavini
Copy link
Author

@srl295 is this branch merged or just deleted?

@srl295 srl295 reopened this Nov 5, 2024
@srl295 srl295 changed the title CLDR-17754: added Samogitian language CLDR-17754 added Samogitian language Nov 5, 2024
@srl295
Copy link
Member

srl295 commented Nov 5, 2024

@zordsdavini Did not see this one (i thought only @conradarcturus was using that branch)

can you fix your commit so that it doesn't have the colon in it?

If you click Details you can choose the Squash option there.

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@zordsdavini
Copy link
Author

@srl295 tried to fix. I hope I did it correctly

common/main/sgs.xml Outdated Show resolved Hide resolved
@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/sgs.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ddl DDL-SC specific work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants