Remove GN generated files from repo #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
previously approved these changes
Jan 22, 2024
| exec --fail-on-error cargo generate-lockfile | ||
|
|
||
| # These versions should match what is in icu_capi_gn Cargo.toml | ||
| exec --fail-on-error cargo update proc-macro2 --precise 1.0.75 |
There was a problem hiding this comment.
thought: can we specify this with an = bound in Cargo.toml?
There was a problem hiding this comment.
i guess that would end up with them getting public gn targets. hm.
There was a problem hiding this comment.
Would it work for the cargo resolver if I listed the versions as build-dependencies or dev-dependencies?
| @@ -1,3 +1,6 @@ | |||
| out/ | |||
| third_party_tools/ | |||
| vendor/ | |||
| .cargo/config | |||
| icu4x/BUILD.gn | |||
| Cargo.lock | |||
There was a problem hiding this comment.
question: the file is gitignored but still checked in to git. intentional?
(I can see wanting to do this for a file that you want to "seed" but don't care about diffs for, and will require an explicit git add to modify. which seems appropriate-ish)
There was a problem hiding this comment.
It was supposed to be deleted. Fixed
Manishearth
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3006
Including some changes in the Cargo Make script for this to work.
The directory can be moved in a clean follow-up PR.