Move ffi/gn to docs/tutorials/gn #4535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manishearth
approved these changes
Jan 22, 2024
| @@ -103,7 +103,7 @@ members = [ | |||
| # implicitly excluded from the main workspace. | |||
| exclude = [ | |||
| # GNaw needs to be run from outside the workspace for features to work | |||
| "ffi/gn", | |||
| "docs/tutorials/gn", | |||
There was a problem hiding this comment.
nit: docs is already excluded
There was a problem hiding this comment.
should we move this file into docs/tutorials/gn? there's significant logic here that needs to be discoverable.
There was a problem hiding this comment.
It defines the root, which must be an ancestor of code being built
| icu_capi = { version = "1.0", path = "../../ffi/capi", default-features = false, features = ["default_components"] } | ||
| icu = { version = "1.0", path = "../../components/icu", default-features = false } | ||
| icu_provider = { version = "1.0", path = "../../provider/core" } | ||
| icu_capi = { version = "1.0", default-features = false, features = ["default_components"] } |
There was a problem hiding this comment.
just to double check: the explicit paths are being replaced by the tutorial patch file?
| @@ -4,7 +4,7 @@ | |||
|
|
|||
| group("default") { | |||
| deps = [ | |||
| "//ffi/gn/hello_world:print_hello", | |||
| "//ffi/gn/icu4x:icu_capi" | |||
| "//docs/tutorials/gn/hello_world:print_hello", | |||
There was a problem hiding this comment.
is there a way to define the root as docs/tutorials/gn?
There was a problem hiding this comment.
Either this or using a symlink; prefer making the GN root the repo root. Clients vendoring ICU4X don't need this part of the setup
sffc
added a commit
to sffc/omnicu
that referenced
this pull request
Jan 24, 2024
robertbastian
pushed a commit
that referenced
this pull request
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3006