Remove forward-compatibility promise and all reserved & private syntax #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
added
syntax
aphillips
approved these changes
Sep 9, 2024
macchiati
reviewed
Sep 10, 2024
eemeli
added a commit
to messageformat/messageformat
that referenced
this pull request
Sep 11, 2024
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #881
As discussed today, we should remove the promise that a 2.0 parser will be able to deal with 2.1 syntax, and accordingly remove all reserved syntax (because with that stability policy change, all such reservations are unnecessary).
As noted in #881, this removes a major reason for private-use annotations, which I'm proposing to remove here as well.
As annotation is now exactly the same as function, these two definitions are merged.
The Unsupported Statement and Unsupported Annotation errors are removed, and their corresponding tests are now syntax error tests.