Skip to content

Commit

Permalink
fix #83
Browse files Browse the repository at this point in the history
you could've just pr'd this
  • Loading branch information
wagyourtail committed Jul 31, 2024
1 parent 95dd6a7 commit f17c854
Showing 1 changed file with 8 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -70,10 +70,14 @@ class MappingsProvider(project: Project, minecraft: MinecraftConfig, val mapping

override fun calamus(key: String, action: MappingDepConfig.() -> Unit) {
project.unimined.ornitheMaven()
val environment = when (side) {
EnvType.CLIENT -> "-client"
EnvType.SERVER -> "-server"
else -> ""
val environment = if (minecraft.minecraftData.mcVersionCompare(minecraft.version, "1.3") < 0) {
when (side) {
EnvType.CLIENT -> "-client"
EnvType.SERVER -> "-server"
else -> throw IllegalStateException("Cannot use calamus with side COMBINED")

This comment has been minimized.

Copy link
@halotroop2288

halotroop2288 Jul 31, 2024

Contributor

Should say "Cannot use Calamus on Minecraft ${minecraft.version} with side COMBINED"

The way it is written implies to the user that Calamus can never be used with combined, but it can.

}
} else {
""
}
mapping("net.ornithemc:calamus-intermediary:${minecraft.version}${environment}:v2", key) {
outputs("intermediary", false) { listOf("official") }
Expand Down

0 comments on commit f17c854

Please sign in to comment.