sources jar remapping #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seems to work, not sure if automatically configuring it is good though
wagyourtail
requested changes
Oct 9, 2024
| import javax.inject.Inject | ||
| import kotlin.io.path.* | ||
|
|
||
| abstract class RemapSourcesJarTaskImpl @Inject constructor(provider: MinecraftConfig): RemapJarTaskImpl(provider) { |
There was a problem hiding this comment.
I don't like this extending RemapJar, imo it'd make more sense if you made an AbstractRemapJarTask that they both implemented. mainly so things like tasks.withType don't accidentally target both when they don't mean to
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds a function
MinecraftConfig.remapSourcesjust likeremap, along with supporting infrastructure to remap said sources (RemapSourcesJarTaskImpl)tests in
1.21-NeoForged-Fabric