Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing wildcard ALB ingress rule #99

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Conversation

jpl-btlunsfo
Copy link
Contributor

Purpose

Proposed Changes

  • REMOVE SecurityGroupIngress entry from ALBSecurityGroup in the cloudformation template

Issues

Testing

  • Manually deployed a management console instance, and ensured through testing and checking in the AWS console that the securitygroup had no ingress rules.

This will be added by the unity-proxy terraform post-install
@jpl-btlunsfo jpl-btlunsfo self-assigned this Sep 5, 2024
Copy link
Collaborator

@galenatjpl galenatjpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@jpl-btlunsfo jpl-btlunsfo merged commit 72aea9b into main Sep 5, 2024
1 of 2 checks passed
@jpl-btlunsfo jpl-btlunsfo deleted the 431-lockdown-mc-alb branch September 5, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants