Moving HTTPD configuration to SSM parameters #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will be testing with a proper management console deployment over the next few days. |
Kicking all of the new ssm parameters to their own TF file for sanity Pulling the virtualhost definitions out of the startup py and into actual ssm definitions, which should allow us to add additional virtualhosts down the line, if necessary
jpl-btlunsfo
force-pushed
the
403-ssm-httpd-config
branch
from
b3015c7
to
d85bc77
Compare
|
All right, I think this is finally tested and generally ready to merge in. Just to note, with all of the changes involved here, this line will need to be changed to whatever (actual) version number this will be built as. unity-proxy/terraform-unity/variables.tf Line 38 in 8cafef3 Right now, it's just pointing at a copy of the image I manually built and pushed. Unfortunately the management console doesn't respect the variables provided by the marketplace entry, so this line has to be hardcoded, and is the only control (until such time as the management console parameterizes it properly). |
mike-gangl
requested changes
May 30, 2024
Also replacing every instance of deployment_name and install_prefix with project-venue
|
@mike-gangl @galenatjpl ready for actual merge, I think. |
galenatjpl
reviewed
May 30, 2024
galenatjpl
reviewed
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving the httpd configuration for the unity-proxy container to SSM parameters, to let us fetch them on container startup.
Should ease the heartburn of unity-sds/unity-cs#403.