jscript: don't attempt to generate tags for empty properties #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In javascript it is legal to have e.g. {"": false} and with the
current code the parser attempts to generate the tag for the empty
string which produces warning.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4153 +/- ##
=======================================
Coverage 85.90% 85.90%
=======================================
Files 239 239
Lines 58727 58728 +1
=======================================
+ Hits 50447 50448 +1
Misses 8280 8280 ☔ View full report in Codecov by Sentry. |
|
I'll cherry-pick the test case from here. |
masatake
pushed a commit
to masatake/ctags
that referenced
this pull request
Dec 13, 2024
In javascript it is legal to have e.g. {"": false}. With the
original code the parser attempts to generate the tag for the empty
string which produces warning.
With setting allowNullTag member of tagEntryInfo, the parser can
generate such tags without producing warnings.
Actual tag emission is controlled by --extras=+{nulltag}.
This commit is based on the commit in universal-ctags#4153.
Co-Author: Masatake YAMATO <[email protected]>
masatake
pushed a commit
to masatake/ctags
that referenced
this pull request
Dec 14, 2024
In javascript it is legal to have e.g. {"": false}. With the
original code the parser attempts to generate the tag for the empty
string which produces warning.
With setting allowNullTag member of tagEntryInfo, the parser can
generate such tags without producing warnings.
Actual tag emission is controlled by --extras=+{nulltag}.
This commit is based on the commit in universal-ctags#4153.
Co-Author: Masatake YAMATO <[email protected]>
masatake
pushed a commit
to masatake/ctags
that referenced
this pull request
Dec 14, 2024
In javascript it is legal to have e.g. {"": false}. With the
original code the parser attempts to generate the tag for the empty
string which produces warning.
With setting allowNullTag member of tagEntryInfo, the parser can
generate such tags without producing warnings.
Actual tag emission is controlled by --extras=+{nulltag}.
This commit is based on the commit in universal-ctags#4153.
Co-Author: Masatake YAMATO <[email protected]>
masatake
pushed a commit
to masatake/ctags
that referenced
this pull request
Dec 14, 2024
In javascript it is legal to have e.g. {"": false}. With the
original code the parser attempts to generate the tag for the empty
string which produces warning.
With setting allowNullTag member of tagEntryInfo, the parser can
generate such tags without producing warnings.
Actual tag emission is controlled by --extras=+{nulltag}.
This commit is based on the commit in universal-ctags#4153.
Co-Author: Masatake YAMATO <[email protected]>
masatake
pushed a commit
to masatake/ctags
that referenced
this pull request
Dec 19, 2024
In javascript it is legal to have e.g. {"": false}. With the
original code the parser attempts to generate the tag for the empty
string which produces warning.
With setting allowNullTag member of tagEntryInfo, the parser can
generate such tags without producing warnings.
Actual tag emission is controlled by --extras=+{nulltag}.
This commit is based on the commit in universal-ctags#4153.
Co-Author: Masatake YAMATO <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In javascript it is legal to have e.g.
{"": false}and with the current code the parser attempts to generate the tag for the empty string which produces warning.This is an attempt to fix #4134. I'm actually not sure why I got the other 2 warnings as I cannot reproduce them now - I possibly just used an old ctags version before.
Fixes #4134.