Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for stackblitz #117

Merged
merged 4 commits into from
Feb 20, 2025
Merged

fix: workaround for stackblitz #117

merged 4 commits into from
Feb 20, 2025

Conversation

pi0
Copy link
Member

@pi0 pi0 commented Feb 20, 2025

resolves #115

Workaround for stackblitz as digest('base64url') does not works but digest(): Buffer chained with .toString('base64url') does work.

On slow paths (Node.js 18, <21.7, <20.12) (see #116), it has downgrades performance from 728,011 rps to 533,944 (using runtime detection, only adds few bundle overhead bits)

@pi0 pi0 marked this pull request as draft February 20, 2025 16:57
@pi0 pi0 marked this pull request as ready for review February 20, 2025 17:08
@pi0 pi0 merged commit f4c78e2 into main Feb 20, 2025
2 checks passed
@pi0 pi0 deleted the fix/stackblitz-hash branch February 20, 2025 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

createHash().digest('base64url') is not supported in stackblitz environment
1 participant