perf(serialize): faster serialization and less bundle size #126
+31
−54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By removing the additional handlers added to
Serializer
and handling them directly inserialize()
we can further improve performance and reduce bundle size. I understand that this breaks the concept of this class but the performance gains worth it in my opinion.toComparableString()
can also be removed becauseserialize()
will be much faster for simple types. (for comparing strings an additional flag is required to further improve performance)Benchmarks
Bundle size
Notes
This modification resulted in +300% performance gains in some presets.